ci: move building the go binaries outside of the Docker image to speed up builds #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d up builds Signed-off-by: Casey Buto <cbuto@d2iq.com>
717bdfb to
d82548e
Compare
jdolitsky
approved these changes
Feb 4, 2022
Contributor
jdolitsky
left a comment
There was a problem hiding this comment.
Lets throw it against CI and see what happens here :)
main should produce canary image(s) so we can test them out
nerdeveloper
pushed a commit
to nerdeveloper/chartmuseum
that referenced
this pull request
Feb 10, 2022
…d up builds (helm#544) Signed-off-by: Casey Buto <cbuto@d2iq.com> Signed-off-by: nerdeveloper <odirionye@gmail.com>
nerdeveloper
pushed a commit
to nerdeveloper/chartmuseum
that referenced
this pull request
Feb 10, 2022
…d up builds (helm#544) Signed-off-by: Casey Buto <cbuto@d2iq.com> Signed-off-by: nerdeveloper <odirionye@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #539. I tested this locally as much as possible using
actwith some of the build steps commented out.This commit moves the building of the chartmuseum binaries out of the Docker image and uses
make build-crossearly on in the job to build all the binaries. Then the Docker image will copy in the proper binary based on theTARGETARCHbuild arg.Building the images is now super quick, although some of that time was moved to the
make build-crossstep. However, now we only have to download go modules once instead of N number of times (where N = number of architectures).I also combined the build and push steps since it seemed like an innocent change (like @jdolitsky mentioned in the issue) 🤞.