Skip to content

pkg/chartmuseum/server: upload chart should emit updateChart event with overwrite option is set #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jdolitsky merged 2 commits into from
May 5, 2021
Merged

pkg/chartmuseum/server: upload chart should emit updateChart event with overwrite option is set #454

jdolitsky merged 2 commits into from
May 5, 2021

Conversation

@scbizu
Copy link
Contributor

@scbizu scbizu commented May 3, 2021 •
edited
Loading

Try to fix #450

@scbizu scbizu added this to the v0.13.2 milestone May 3, 2021
@scbizu scbizu self-assigned this May 3, 2021
@helm-bot helm-bot added the size/S label May 3, 2021
@scbizu scbizu force-pushed the fix/duplicate-index-entry branch from 9735d64 to 66cc263 Compare May 3, 2021 07:10
@helm-bot helm-bot added size/M and removed size/S labels May 3, 2021
@scbizu scbizu force-pushed the fix/duplicate-index-entry branch from ee16a92 to 2f9f2f0 Compare May 3, 2021 08:32
@scbizu scbizu added the go Pull requests that update Go code label May 3, 2021
@scbizu
pkg/chartmuseum/server/multitenant: fix the bad action type when upload
cd2e286 
package when overwrite option is set ,index entry addChart should be updateChart under the overwrite cases.

Signed-off-by: scnace <scbizu@gmail.com>
@scbizu scbizu force-pushed the fix/duplicate-index-entry branch from 2f9f2f0 to cd2e286 Compare May 3, 2021 08:40
@scbizu scbizu changed the title [WIP] pkg/chartmuseum/server: add tests for cover duplicate index entry cases pkg/chartmuseum/server: upload chart should emit updateChart event with overwrite option is set May 3, 2021
@scbizu scbizu requested a review from jdolitsky May 3, 2021 08:47
@scbizu scbizu mentioned this pull request May 4, 2021
Closed
jdolitsky
jdolitsky approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@jdolitsky jdolitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jdolitsky jdolitsky merged commit d311914 into main May 5, 2021
@scbizu scbizu mentioned this pull request Jun 14, 2021
Merged
1 task
@jdolitsky jdolitsky modified the milestones: v0.13.2, v0.14.0 Sep 3, 2021
@stonezdj stonezdj mentioned this pull request Sep 23, 2021
Closed
ninjadq added a commit to ninjadq/chartmuseum that referenced this pull request Sep 24, 2021
@ninjadq
Fix duplicate versions for same chart
855c712 
* The detailed issue is described in helm#450
* And there is a PR helm#454 fixed one scenario of this issue
* But there is another ocassion in which users upload chart with prov
* in this PR is to handle this situation with the way similar with helm#454

Signed-off-by: DQ <dengq@vmware.com>
@ninjadq ninjadq mentioned this pull request Sep 24, 2021
Merged
ninjadq added a commit to ninjadq/chartmuseum that referenced this pull request Sep 25, 2021
@ninjadq
Fix duplicate versions for same chart
bd2d518 
* The detailed issue is described in helm#450
* And there is a PR helm#454 fixed one scenario of this issue
* But there is another ocassion in which users upload chart with prov
* in this PR is to handle this situation with the way similar with helm#454

Signed-off-by: DQ <dengq@vmware.com>
ninjadq added a commit to ninjadq/chartmuseum that referenced this pull request Sep 25, 2021
@ninjadq
Fix duplicate versions for same chart
ccc3675 
* The detailed issue is described in helm#450
* And there is a PR helm#454 fixed one scenario of this issue
* But there is another ocassion in which users upload chart with prov
* in this PR is to handle this situation with the way similar with helm#454

Signed-off-by: DQ <dengq@vmware.com>
ninjadq added a commit to ninjadq/chartmuseum that referenced this pull request Sep 25, 2021
@ninjadq
Fix duplicate versions for same chart
fba104a 
* The detailed issue is described in helm#450
* And there is a PR helm#454 fixed one scenario of this issue
* But there is another ocassion in which users upload chart with prov
* in this PR is to handle this situation with the way similar with helm#454

Signed-off-by: DQ <dengq@vmware.com>
ninjadq added a commit to ninjadq/chartmuseum that referenced this pull request Sep 26, 2021
@ninjadq
Fix duplicate versions for same chart
c1a1020 
* The detailed issue is described in helm#450
* And there is a PR helm#454 fixed one scenario of this issue
* But there is another ocassion in which users upload chart with prov
* in this PR is to handle this situation with the way similar with helm#454

Signed-off-by: DQ <dengq@vmware.com>
ninjadq added a commit to ninjadq/chartmuseum that referenced this pull request Sep 26, 2021
@ninjadq
Fix duplicate versions for same chart
5dd7f03 
* The detailed issue is described in helm#450
* And there is a PR helm#454 fixed one scenario of this issue
* But there is another ocassion in which users upload chart with prov
* in this PR is to handle this situation with the way similar with helm#454

Signed-off-by: DQ <dengq@vmware.com>
scbizu pushed a commit that referenced this pull request Sep 30, 2021
@ninjadq
Fix duplicate versions for same chart (#492)
670c99e 
* Fix duplicate versions for same chart

* The detailed issue is described in #450
* And there is a PR #454 fixed one scenario of this issue
* But there is another ocassion in which users upload chart with prov
* in this PR is to handle this situation with the way similar with #454

Signed-off-by: DQ <dengq@vmware.com>

* Enhance: optimize loop in `getChartAndProvFiles`

* If conflict, it didn't need to do the left logic, just return the file
* move out file format check logic out of `validateChartOrProv`
* these changes are discussed in #492 (comment)

Signed-off-by: DQ <dengq@vmware.com>
@jdolitsky jdolitsky deleted the fix/duplicate-index-entry branch January 28, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdolitsky jdolitsky jdolitsky approved these changes

Assignees

@scbizu scbizu

Labels

go Pull requests that update Go code size/M

Projects

None yet

Milestone

v0.14.0

Development

Successfully merging this pull request may close these issues.

Duplicate versions for same chart

4 participants

@scbizu @jdolitsky @helm-bot