bug(493): Improved git remote parsing #726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8ccc9c0 to
31ce04a
Compare
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Contributor
Author
|
This is still valid. Please review and merge. |
Member
|
@rickard-von-essen can you rebase and resolve the conflict? |
Previously this would fail to parse git remotes like: ssh://github.com/foo/bar ssh://github.com:2222/foo/bar This properly parses hostname from both URLs and scp style remotes. Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
31ce04a to
9b319fc
Compare
Contributor
Author
|
@cpanato rebased |
Member
|
@rickard-von-essen there is a lint issue |
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
1511648 to
eae288c
Compare
Contributor
Author
|
Fixed in eae288c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this would fail to parse git remotes like:
This properly parses hostname from both URLs and scp style remotes.
Fixes #493