-
Notifications
You must be signed in to change notification settings - Fork 246
Closed
Labels
Description
Is this a request for help?: no
Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT
Version of Helm and Kubernetes:
version.BuildInfo{Version:"v3.10.1", GitCommit:"v3.10.1", GitTreeState:"", GoVersion:"go1.19.2"}
WARNING: This version information is deprecated and will be replaced with the output from kubectl version --short. Use --output=yaml|json to get the full version.
Client Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.3", GitCommit:"434bfd82814af038ad94d62ebe59b133fcb50506", GitTreeState:"archive", BuildDate:"1980-01-01T00:00:00Z", GoVersion:"go1.19.2", Compiler:"gc", Platform:"darwin/amd64"}
Kustomize Version: v4.5.7
Version: 3.7.1
Git commit: v3.7.1
Date: 19700101-00:00:00
License: Apache 2.0
What happened:
Validating maintainers...
------------------------------------------------------------------------------------------------------------------------
✖︎ chart => (version: "0.1.0", path: "chart") > could not parse git repository domain for "github.enterprise:org/repo"
------------------------------------------------------------------------------------------------------------------------
Error: failed linting charts: failed processing charts
failed linting charts: failed processing charts
What you expected to happen:
Validating maintainers...
------------------------------------------------------------------------------------------------------------------------
✔︎ chart => (version: "0.1.0", path: "chart")
------------------------------------------------------------------------------------------------------------------------
Error: failed linting charts: failed processing charts
failed linting charts: failed processing charts
How to reproduce it (as minimally and precisely as possible):
git clone github.enterprise:org/repo # user, routing, and custom credential configuration exists in ~/.ssh/config
cd repo
ct lintAnything else we need to know:
It looks like
chart-testing/pkg/tool/account.go
Line 25 in e5e506e
| var repoDomainPattern = regexp.MustCompile("(?:https://(?:[^@:]+:[^@:]+@)?|git@)([^/:]+)") |
git@.
While this regex could be expanded to match more use cases, it may be easier simply hand off the remote host directly via config, as some corporate environments make introspecting these domains tricky.
kevinfalting