Skip to content

ci(sycl): drop auto-triggers (workflow has zero jobs upstream)#74

Merged
marksverdhei merged 1 commit into
htfrom
fix/disable-sycl-ci-trigger
Jun 12, 2026
Merged

ci(sycl): drop auto-triggers (workflow has zero jobs upstream)#74
marksverdhei merged 1 commit into
htfrom
fix/disable-sycl-ci-trigger

Conversation

@marksverdhei

Copy link
Copy Markdown

Epoch #73 task 1: CI health.

What

All SYCL jobs in .github/workflows/build-sycl.yml are commented out upstream (ggml-org/llama.cpp#23705) to save GitHub Actions resources. With the upstream auto-triggers (push to master, pull_request matching ggml/src/ggml-sycl/**) still firing, every fork-sync that touches master creates a zero-job "failure" run and pollutes our Actions dashboard.

Diff

Strip push + pull_request blocks from on:; keep workflow_dispatch so the job stays manually invokable.

 on:
   workflow_dispatch: # allows manual triggering
-  push:
-    branches:
-      - master
-    paths: [
-      '.github/workflows/build-sycl.yml',
-      '**/CMakeLists.txt',
-      ...
-    ]
-
-  pull_request:
-    types: [opened, synchronize, reopened]
-    paths: [
-      '.github/workflows/build-sycl.yml',
-      'ggml/src/ggml-sycl/**'
-    ]

Maintenance note

Master sync (ggml-org#119 was the last one) brings in the upstream version of this file, which re-introduces the auto-triggers. The note in the file body explains what to re-apply after a sync. Filing as a recurring 'fix after master sync' item; may want a CI-side check that flags zero-job workflow runs eventually.

Verified

  • python3 -c 'import yaml; yaml.safe_load(open(".github/workflows/build-sycl.yml"))' — YAML parses
  • workflow_dispatch:-only workflows are valid in GitHub Actions (no jobs: block required when there are no auto-triggers; though we still keep the commented-out block intact for the manual dispatch path to invoke when re-enabled)

All SYCL jobs in this workflow are commented out upstream (PR
ggml-org#23705) to save Actions resources. With the upstream
auto-triggers (push to master, pull_request matching ggml/src/ggml-sycl/**)
still firing, every fork-sync that touches master creates a zero-job
'failure' run, polluting our Actions dashboard.

Strip the auto-triggers on ht; keep workflow_dispatch so the job stays
manually invokable if/when upstream re-enables SYCL CI. Will need to be
re-applied after future master syncs that pull in the upstream version
of this file.
@marksverdhei marksverdhei merged commit 1313a88 into ht Jun 12, 2026
@marksverdhei marksverdhei deleted the fix/disable-sycl-ci-trigger branch June 12, 2026 18:31
marksverdhei added a commit that referenced this pull request Jun 12, 2026
Same pattern as PR #74 (build-sycl.yml): upstream PR ggml-org#23705 commented
out every job in this workflow, but the push:master + pull_request
auto-triggers stayed live. Any PR touching ggml/src/ggml-cann/** would
create a zero-job "failure" run.

Keep workflow_dispatch so the workflow stays available for manual
runs once jobs are re-enabled (which requires provisioning dedicated
runners per the upstream TODO).

Co-authored-by: marksverdhei <mark.sverdhei@gmail.com>
marksverdhei added a commit that referenced this pull request Jun 12, 2026
…#105)

* ci: unbreak fork CI — dead self-hosted labels + invalid sycl workflow

Three fork-side CI defects, all inherited from upstream's runner topology:

- build-cmake-pkg.yml: [self-hosted, Linux, CPU] matches no runner in this
  org (only ht-org-k8s-* with Linux,X64,k8s exists) -> the job queued
  forever and the 'CI (cpu)' workflow has never concluded since the
  2026-06-07 CI refactor sync. GitHub-hosted ubuntu-latest (repo is public).

- python-lint.yml: [self-hosted, fast] same story; flake8 dead-queued on
  every push since 2026-05-24. ubuntu-latest.

- build-sycl.yml: #74 stripped the auto-triggers, but the file itself is
  schema-INVALID (all jobs commented out = empty jobs map), and GitHub
  creates a zero-job 'failure' run on every push for invalid workflows
  regardless of triggers. Add a never-running placeholder job so the file
  parses; drop it when upstream re-enables SYCL CI.

* ci(lint): flake8 green — NP100 per-file-ignores for stdout CLIs + drop unused np binding

The linter has been dead-queued since 2026-05-24 (runner label); reviving
it surfaced 36 violations, all in downstream diagnostic scripts:

- scripts/{gguf-meta,compare-dflash-weights,dflash-logit-parity}.py write
  their reports to stdout by design — NP100 (no print(), use logging)
  targets library code. Per-file-ignores in .flake8.
- dflash-logit-parity.py: F841 — numpy presence-check kept, dead binding
  dropped.

---------

Co-authored-by: marksverdhei <mark.sverdhei@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant