-
Notifications
You must be signed in to change notification settings - Fork 214
Japanese localization: Fix some typos and grammatical errors #940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Converted to draft as the merging of this requires an update to the submodule and the font atlas to be updated in the https://www.github.com/hedge-dev/UnleashedRecompResources Additional note to self: Check how the new text looks in the menus and ask @brianuuu to review the changes after. |
brianuuu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this, I knew I shouldn't have changed します to されます for some of them, just a few issues and should be good to go
|
Thank you for your review. I have corrected the errors you mentioned. 「されます」 is generally used in passive constructions or when referring to someone of higher status. In this case, the subject is the game, and the game is performing an action related to the options. It is neither passive nor higher status. Therefore, 「します」 should be used instead. |
I have fixed some typos and grammatical errors in Japanese option screen text.

I'm sorry, but since I don't own the font, I couldn't compile the font atlas and therefore couldn't check whether the text fits in the description box.
Especially this one: