Skip to content

Conversation

@Kuid0us
Copy link
Contributor

@Kuid0us Kuid0us commented Mar 4, 2025

I have fixed some typos and grammatical errors in Japanese option screen text.
I'm sorry, but since I don't own the font, I couldn't compile the font atlas and therefore couldn't check whether the text fits in the description box.
Especially this one:
image

@DeaTh-G DeaTh-G marked this pull request as draft March 4, 2025 13:27
@DeaTh-G
Copy link
Contributor

DeaTh-G commented Mar 4, 2025

Converted to draft as the merging of this requires an update to the submodule and the font atlas to be updated in the https://www.github.com/hedge-dev/UnleashedRecompResources

Additional note to self: Check how the new text looks in the menus and ask @brianuuu to review the changes after.

@DeaTh-G DeaTh-G added this to the v1.0.2 milestone Mar 4, 2025
Copy link
Contributor

@brianuuu brianuuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this, I knew I shouldn't have changed します to されます for some of them, just a few issues and should be good to go

@Kuid0us
Copy link
Contributor Author

Kuid0us commented Mar 5, 2025

Thank you for your review. I have corrected the errors you mentioned.

「されます」 is generally used in passive constructions or when referring to someone of higher status. In this case, the subject is the game, and the game is performing an action related to the options. It is neither passive nor higher status. Therefore, 「します」 should be used instead.

@hyperbx hyperbx added the resources needed Needs new or updated resources for merging label Mar 6, 2025
@blueskythlikesclouds blueskythlikesclouds modified the milestones: v1.0.2, v1.0.3 Mar 7, 2025
@blueskythlikesclouds blueskythlikesclouds marked this pull request as ready for review March 25, 2025 16:31
@blueskythlikesclouds blueskythlikesclouds merged commit e1f773d into hedge-dev:main Mar 25, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

resources needed Needs new or updated resources for merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants