Add hidden DisableDPadAsAnalogInput option #604
Conversation
|
The d-pad controls are added into the recompilation as an enhancement and are purposefully not exposed on a toggle. |
|
I understand, maybe this option could still exist while staying on by default? I know that it personally does bother me a bunch, it can be annoying for some tricks in the game. |
|
What tricks can it be problematic with? Does it get in the way of some pausing tricks or similar? |
|
It's probably not things that a casual player would run into but for example with speedrunning, there is one notorious trick named XP glitch where the dpad and the left stick are used at the same time and it does not really play nicely. |
|
Oh okay, that's valid. |
1763117 to
93a1db3
Compare
|
Okay, I've inverted the option so that the dpad movement is enabled by default and I changed it's name to DisableDPadAsAnalogInput instead. |
93a1db3 to
c454c83
Compare
blueskythlikesclouds
left a comment
There was a problem hiding this comment.
I see a few issues:
- Space hurrier hooks aren't checking for the bool.
- IsDPadThreshold isn't checking for the bool, causing the DS4/DualSense touchpad to stop if you press the D-Pad keys despite them not moving the cursor.
|
Right, I didn't touch these as I wasn't sure what they were doing. Also, I don't have access to a DS4 controller so I won't be able to test this. Either way, I'll get to this later today. |
This commit adds a configuration entry in the 'Codes' section named DisableDPadAsAnalogInput allowing someone to enable or disable the movement of Sonic / the world map cursor using the directional pad buttons.
c454c83 to
23900ca
Compare
|
Alright, again, I can't test these changes as I don't have a DS4 and I don't know what SpaceHurrier is but i think that's what you wanted me to add, right? |
|
|
|
Ah alright, that makes more sense now, thanks for that information. |
|
Interestingly, from my testing, it looks like those space hurrier hooks might not even be needed. If I remove their entire code, when the dpad analog input is enabled, Gaia Colossus still moves. He doesn't move when the analog input is disabled regardless of whether the original hook code runs or not. Unless the space hurrier posture doesn't actually mean the movement of Gaia Colossus? |
|
They're needed for the leaning animations. |
|
Fair enough, I didn't quite understand it i suppose, apologies for my lack of knowledge on all this 😅 |
|
Hi, as a former unleashed runner I gotta say that moving sonic with the dpad buttons is very annoying to me as it makes some speedrun tricks very hard to perform. I know it was added as an enhanced to the game, but I'd love if we could disable it. So my question is: is this going to be added in the future? Please do it or I will need to buy a xbox controller (I have a ps5 controller) |
|
This PR adds the ability to disable D-Pad support using a HMM code, please wait for v1.0.2. |
|
Thank you so much. |
|
Thank you for the merge! I just have one last question, do you want me to make a PR to the HMMCodes repository to add the code or do you guys prefer to handle that yourselves? |
Enabling this code will disable analog movement with the dpad (Sonic's movement, the world map cursor movement...). The dpad will still work for the menus. See hedge-dev/UnleashedRecomp#604.
Enabling this code will disable analog movement with the dpad (Sonic's movement, the world map cursor movement...). The dpad will still work for the menus. See hedge-dev/UnleashedRecomp#604.
This PR adds a configuration entry in the 'Codes' section named DPadAsAnalogInput allowing someone to enable or disable the movement of Sonic / the world map cursor using the directional pad buttons.
This default behavior on the original game was to not move Sonic / the world map cursor when the dpad was used, I thought it would be good to let people choose this if they want. Let me know if anything else needs to be changed.