Removes constructor override on service object generators. #4174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one has a lot of coding standard errors, as well as a malformed namespace. I have not attempted to fix those, as they are out of scope for this issue, although I fixed them for the create() function, since that's directly related to what I'm changing.
This one has some coding standard errors. I have not attempted to fix those, as they are out of scope for this issue, although I fixed them for the create() function and the currentUser property definition, since that's directly related to what I'm changing.
This one has some coding standard errors. I have not attempted to fix those, as they are out of scope for this issue, although I fixed them for the create() function and the property definitions, since that's directly related to what I'm changing.
Contributor
|
Hi @GueGuerreiro I tested your pr but using the command drupal gcon I have an error, could you please check this error?
|
Contributor
Author
|
Hi @nequeteme, this PR won't work unless you also apply hechoendrupal/drupal-console-core#369. That one adds the missing |
Contributor
|
Thanks |
GueGuerreiro
added a commit
to GueGuerreiro/drupal-console
that referenced
this pull request
Nov 9, 2019
When the class itself is implementing ContainerFactoryPluginInterface, we do not have a parent create method we can use.
enzolutions
pushed a commit
that referenced
this pull request
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #4169.
It requires hechoendrupal/drupal-console-core#369 to be merged first, for a few of the generators that use the function Twig function
serviceClassInjection.