Skip to content

Add missing genrule to com_github_ivmai_cudd/bundled.BUILD.bazel#395

Merged
mikesinouye merged 5 commits into
hdl:mainfrom
maliberty:cudd-genrule-fix
Mar 26, 2025
Merged

Add missing genrule to com_github_ivmai_cudd/bundled.BUILD.bazel#395
mikesinouye merged 5 commits into
hdl:mainfrom
maliberty:cudd-genrule-fix

Conversation

@maliberty

@maliberty maliberty commented Mar 24, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@QuantamHD

QuantamHD commented Mar 24, 2025

Copy link
Copy Markdown
Collaborator

/gcbrun

@mikesinouye

mikesinouye commented Mar 24, 2025

Copy link
Copy Markdown
Collaborator

/gcbrun

1 similar comment
@QuantamHD

QuantamHD commented Mar 24, 2025

Copy link
Copy Markdown
Collaborator

/gcbrun

@maliberty

maliberty commented Mar 24, 2025

Copy link
Copy Markdown
Contributor Author

I can't see the error for hdl-bazel-rules-hdl-pr. When I try to follow the link to https://console.cloud.google.com/cloud-build/builds/a6a3232b-e43c-4455-b697-5e6daeffe0ed?project=140684304 I get

Missing permissions:
  cloudbuild.builds.get

@mikesinouye

mikesinouye commented Mar 24, 2025

Copy link
Copy Markdown
Collaborator

I can't see the error for hdl-bazel-rules-hdl-pr. When I try to follow the link to https://console.cloud.google.com/cloud-build/builds/a6a3232b-e43c-4455-b697-5e6daeffe0ed?project=140684304 I get

Missing permissions:
  cloudbuild.builds.get

The failure is unrelated to your PR, and the fix is already submitted (70f93e4). Let me re-run the check.

@mikesinouye

mikesinouye commented Mar 25, 2025

Copy link
Copy Markdown
Collaborator

Can you re-base the PR?

@maliberty
Add missing genrule to com_github_ivmai_cudd/bundled.BUILD.bazel
56bb2c2 
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
@maliberty
add build_test to cudd
4c83bd9 
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
@maliberty
rm build_test from cudd
b5dd0ae 
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
@maliberty

maliberty commented Mar 25, 2025

Copy link
Copy Markdown
Contributor Author

Can you re-base the PR?

done

@mikesinouye

mikesinouye commented Mar 25, 2025

Copy link
Copy Markdown
Collaborator

/gcbrun

@maliberty
correct package name in com_github_ivmai_cudd.bzl comments
12857b1 
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
@maliberty
make cudd libraries public visibility
4b7a940 
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
@maliberty

maliberty commented Mar 26, 2025

Copy link
Copy Markdown
Contributor Author

@mikesinouye I put in a few more fixes. I don't know what failed in the last run as I can't see the results. Please let me know so I can address as needed before you trigger the next run.

@maliberty

maliberty commented Mar 26, 2025

Copy link
Copy Markdown
Contributor Author

With these changes I get no cudd related build errors (still working on abc).

@mikesinouye

mikesinouye commented Mar 26, 2025

Copy link
Copy Markdown
Collaborator

The error seemed unrelated:

ERROR: An error occurred during the fetch of repository 'net_sourceforge_ngspice':
Error in fail: error running 'git fetch origin refs/heads/*:refs/remotes/origin/* refs/tags/*:refs/tags/*' while working with @net_sourceforge_ngspice:
fatal: Could not read from remote repository.

I am going to run it again to see if the issue was transient.

@mikesinouye

mikesinouye commented Mar 26, 2025

Copy link
Copy Markdown
Collaborator

/gcbrun

@mikesinouye mikesinouye merged commit c0c6884 into hdl:main Mar 26, 2025
@mikesinouye

mikesinouye commented Mar 26, 2025

Copy link
Copy Markdown
Collaborator

Thanks Matt.

@maliberty maliberty deleted the cudd-genrule-fix branch March 26, 2025 18:33
MrAMS pushed a commit to MrAMS/bazel_rules_hdl that referenced this pull request Dec 10, 2025
@maliberty @MrAMS
Add missing genrule to com_github_ivmai_cudd/bundled.BUILD.bazel (hdl…
d1397bf 
…#395)

* Add missing genrule to com_github_ivmai_cudd/bundled.BUILD.bazel

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>

* add build_test to cudd

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>

* rm build_test from cudd

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>

* correct package name in com_github_ivmai_cudd.bzl comments

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>

* make cudd libraries public visibility

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>

---------

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuantamHD QuantamHD QuantamHD approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maliberty @QuantamHD @mikesinouye