feat: allow themes to customise editor error highlight colours#132
Merged
hbenl merged 1 commit intohbenl:masterfrom May 16, 2020
robertrossmann:feat/colour-contribution
Merged
feat: allow themes to customise editor error highlight colours#132hbenl merged 1 commit intohbenl:masterfrom robertrossmann:feat/colour-contribution
hbenl merged 1 commit intohbenl:masterfrom
robertrossmann:feat/colour-contribution
Conversation
This adds a new colour contribution point, `testExplorer.errorDecorationBackground` which theme authors (ie. me 😇) can use to customise the line highlight colour used when a test case fails. The colour inherits from the core colour `inputValidation.errorBackground` which immediatelly improves how the error decoration looks in built-in themes. It fits much more nicely now!
Contributor
Author
|
Any hopes in getting this merged in so I can tweak the highlights in my theme? 🙏 🎨 |
Owner
|
Thanks for the PR. |
Contributor
Author
|
Weeey thanks for merging! 🚀🎉 |
robertrossmann
added a commit
to robertrossmann/vscode-remedy
that referenced
this pull request
May 17, 2020
github-actions bot
pushed a commit
to robertrossmann/vscode-remedy
that referenced
this pull request
May 18, 2020
# [4.14.0](4.13.0...4.14.0) (2020-05-18) ### Features * add debug Console colour contributions 🎨 ([9cd02be](9cd02be)), closes [microsoft/vscode#97762](microsoft/vscode#97762) * customise colours for Test Explorer UI 🎨 ([0d0568f](0d0568f)), closes [hbenl/vscode-test-explorer#132](hbenl/vscode-test-explorer#132)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new colour contribution point,
testExplorer.errorDecorationBackgroundwhich theme authors (ie. me 😇) can use to customise the line highlight colour used when a test case fails. The colour inherits from the core colourinputValidation.errorBackgroundwhich immediatelly improves how the error decoration looks in built-in themes. It fits much more nicely now!