feat(Internal): add constant-time Eq, use Scoped for internals#169
Merged
Kleidukos merged 2 commits intohaskell-cryptography:mainfrom Jan 3, 2025
Merged
Conversation
387ce13 to
f3a7b2f
Compare
jhenahan
commented
Jan 3, 2025
| -- too short. | ||
| -- | ||
| -- @since 0.0.3.0 | ||
| unsafeCopyToSodiumPointer :: CSize -> StrictByteString -> IO (ForeignPtr CUChar) |
Contributor
Author
There was a problem hiding this comment.
This isn't used in this PR, but is used in the next PR in the stack: https://github.com/jhenahan/libsodium-bindings/pull/2/files#diff-6d90c4955b4c0bcc7d190b7109069933f66133e3a46f1fa0a64e6308f33f4707R499
Kleidukos
requested changes
Jan 3, 2025
e1d2031 to
196a346
Compare
Constant-time comparison helps avoid timing attacks on secret cryptographic material. Also adds functions for interacting with `sodium_malloc`'d pointers.
196a346 to
83f92ed
Compare
The previous commit handles `IO` in the instance definitions, so it's no longer necessary to handle it at the use sites.
83f92ed to
18a79fd
Compare
Kleidukos
approved these changes
Jan 3, 2025
Member
|
Cheers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constant-time comparison helps avoid timing attacks on secret cryptographic material.
Also adds functions for interacting with
sodium_malloc'd pointers.Stack