Closed
Conversation
Unforutnately, this also invovles vendoring Brittany with a fork that allows it to build on ghc-8.10.1. This is only vendored on the cabal.project file though, not the stack.yamls
048e389 to
1b0222d
Compare
Collaborator
Author
|
Tracking lspitzner/data-tree-print#2 |
alanz
approved these changes
Aug 5, 2020
Collaborator
alanz
left a comment
There was a problem hiding this comment.
LGTM.
Why not vendoring into stack? No 8.10.1 support yet?
Collaborator
Author
|
@alanz we still need allow-newer for one dependency, but stack only lets you turn on allow-newer for all bounds or none so I thought it would be safer just to leave it |
Collaborator
Author
|
Looks like that branch of Brittany doesn't build on versions other than 8.10, will need to fix https://github.com/bubba/haskell-language-server/runs/949543226?check_suite_focus=true |
Collaborator
Author
|
Needs redone after #264 |
pepeiborra
pushed a commit
that referenced
this pull request
Dec 27, 2020
* Remove JSON instances for completions, since we are not implementing "resolve" * Remove completion resolve data from tests * Better docs * Fix tests * Fix for 8.4 * Turn Haddock markup into Markdown * Add types to completion items * Make it work on 8.8 and 8.4 * Revert "Remove completion resolve data from tests" This reverts commit 625d710f11db2215a886e0a75e35f646190d4b36. * Revert "Remove JSON instances for completions, since we are not implementing "resolve"" This reverts commit 12ff27dce71d06ba2f74aa8b9695aea95368e1d2. * Fix tests * Require higher version of regex-pcre-builtin * Replace Pandoc with direct conversion from Haddock to Markdown * Show kinds of type constructors too * A few fixed to Markdown conversion * Check optNewColonConvention * Fix build on 8.4 and 8.8 * More fixes for 8.4 and 8.8 * Check only the common part of the completion text * Make icons consistent with Outline * Test docs for completions * Make constructors return the corresponding CompletionItem + tests for that behavior * Make test work on 8.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unforutnately, this also invovles vendoring Brittany with a fork that
allows it to build on ghc-8.10.1. This is only vendored on the
cabal.project file though, not the stack.yamls