Merged
Conversation
The original lineno extracted from the Addition DiffOperation needs to be increased by 1.
We were taking max of l and sl but the position of an insertion in the newer document is irrelevant since the edits will be applied from bottom to top.
Closed
pepeiborra
pushed a commit
that referenced
this pull request
Dec 27, 2020
This does not yet take advantage of any new features but we should at least be able to benefit from bugfixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses some inconsistent use of 0/1-indexing in the formatting code. The main issue was in
diffOperationToTextEditwhich is only used by the Ormolu plugin. Also added import lists to formatting testdata for more robust testing.fixes #213