Ignore dependencies that are not Buildable#2731
Closed
kosmikus wants to merge 2 commits intohaskell:masterfrom
Closed
Ignore dependencies that are not Buildable#2731kosmikus wants to merge 2 commits intohaskell:masterfrom
kosmikus wants to merge 2 commits intohaskell:masterfrom
Conversation
When doing the index conversion prior to dependency solving, we now consider the "Buildable" flag for package components. In particular, if the "Buildable" flag of a component is "True" only under certain conditions, then all build dependencies of that component will be placed under the same conditions.
When configuring a package, the condition trees in the package descriptions are evaluated according to the known configuration and flag assignment. During this process, it becomes also known whether a component has its "Buildable" flag set to True or False. We now disregard all dependencies of non-buildable components.
Member
|
Do we need a test for this? |
Contributor
Author
|
@23Skidoo Fair point. I had planned to, but also wanted to get the code out there asap. I'll have a look what I can do. |
Contributor
|
When this is repushed with tests please remove action-required |
Collaborator
|
Would you like me to add some tests for this? |
Member
|
Sure, I think this could be merged if it had tests. |
Member
|
Closing in favour of #3039. |
BardurArantsson
added a commit
that referenced
this pull request
Jan 15, 2016
Tests for #2731 (Ignore dependencies that are not Buildable)
This was referenced Jan 25, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #1725
There are two separate changes here: