fix: replace all dot chars during normalization#580
Conversation
| */ | ||
| function normalizeOutputKey(dataKey, upperCase = false) { | ||
| let outputKey = dataKey | ||
| .replace(".", "__") |
There was a problem hiding this comment.
IIRC we used to wait to update dist/index.js until release time?
There was a problem hiding this comment.
Yes you are correct. I can't remember why I started including this in PRs. But at one point I think I had a good reason... Maybe it was so the main ref was up-to-date in case people wanted to pull that in?
There was a problem hiding this comment.
Yeah I think the concern was that main could be unstable in between releases and could break people that were pointing to @main. But that was early days here, maybe we're not as worried about that now.
There was a problem hiding this comment.
Thanks for the info! I don't feel too strongly about it but I lean toward keeping main up-to-date. I will merge this for now and if we get complaints we can revisit the workflow.
Description
Closes #579
Checklist
Community Note
reaction
to the original pull request comment to help the community and maintainers
prioritize this request
followers and do not help prioritize the request