Skip to content

[BUG] Only first dot (.) of normalized output key is replaced #579

@johannesaracom

Description

@johannesaracom

Vault server version

v1.19.2

vault-action version

v3.3.0

Describe the bug

If multiple dots (.) are contained in the name of a secret, only the first dot is replaced (__). All other dots are removed.

To Reproduce

Create a secret named i.e. my.secret.value
Expected output key: MY__SECRET__VALUE
Actual output key: MY__SECRETVALUE

Expected behavior

According to the documentation and a response to another issue, this is not intended, and all dots should be replaced with __ instead of just the first one.

Additional context

Problem should be this line: .replace(".", "__")

If pattern is a string, only the first occurrence will be replaced.

(see replace )

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions