Merged
Conversation
maxcoulombe
reviewed
Jan 31, 2024
| notFoundMsg = `Unable to retrieve result for "${path}" because it was not found: ${response.body.trim()}`; | ||
| const ignoreNotFound = (core.getInput('ignoreNotFound', { required: false }) || 'false').toLowerCase() != 'false'; | ||
| if (ignoreNotFound) { | ||
| core.error(`✘ ${notFoundMsg}`); |
Contributor
There was a problem hiding this comment.
No strong opinion but I can see this being a warning instead of an error since the input flag tells us a missing secret is acceptable.
Collaborator
Author
There was a problem hiding this comment.
I thought about this a bit and since it is an error returned by Vault I think I will keep it as an error in the action. Thanks @maxcoulombe !
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
ignoreNotFoundinput (default: false) to prevent the action from failing when a secret does not existSupercedes #506
Checklist
dist/index.js(This is only done for releases by vault-action maintainers)Community Note
reaction
to the original pull request comment to help the community and maintainers
prioritize this request
followers and do not help prioritize the request