feat: add new ignoreNotFound input to prevent the action from crashing when requested secrets do not exist#506
feat: add new ignoreNotFound input to prevent the action from crashing when requested secrets do not exist#506tanguy-platsec wants to merge 3 commits intohashicorp:mainfrom tanguy-platsec:handle-ignoreNotFound-input
ignoreNotFound input to prevent the action from crashing when requested secrets do not exist#506Conversation
|
|
ignoreNotFound input to make the secrets not crash when requested secrets do not existignoreNotFound input to prevent the action from crashing when requested secrets do not exist
|
hey @tanguy-platsec, thanks for the PR! Is there an obvious way to add a test for this new scenario? Other than that it looks good to me! |
|
Hello again! |
|
@tanguy-platsec I am curious what your workaround was? |
We simply list the secrets' paths we want to load in a YAML file and we parse it during CI to load them. |
|
Closed by #518 and available in https://github.com/hashicorp/vault-action/releases/tag/v2.8.0 |
Description
Adding an optional input
ignoreNotFoundto make the action keep going even though one of the requested secret is not found (404).We have a specific case where this is useful (necessary to be honest) and we thought it would be a nice improvement to your action codebase, since it is sometimes wanted to have a "always exit success" mecanism in GitHub Actions ecosystem.
Let me know what you think! Of course I can adapt my changes to whatever you prefer, like passing the new input variable from
action.jsto thegetSecretsfunction instead of importingcorein thesecrets.jsfile (wasn't sure what was the best practice there).Checklist
dist/index.js(This is only done for releases by vault-action maintainers)Community Note
reaction
to the original pull request comment to help the community and maintainers
prioritize this request
followers and do not help prioritize the request