Skip to content

fix(gcs): check storage errors correctly#31274

Merged
mpalmi merged 2 commits into
hashicorp:mainfrom
steved:main
Jul 31, 2025
Merged

fix(gcs): check storage errors correctly#31274
mpalmi merged 2 commits into
hashicorp:mainfrom
steved:main

Conversation

@steved

@steved steved commented Jul 14, 2025

Copy link
Copy Markdown
Contributor

Description

After googleapis/google-cloud-go#11519, errors must be checked with errors.Is.

Addresses #31125.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@steved steved requested a review from a team as a code owner July 14, 2025 20:05
@steved steved requested a review from jefferai July 14, 2025 20:05
@hashicorp-cla-app

hashicorp-cla-app Bot commented Jul 14, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

mpalmi
mpalmi previously approved these changes Jul 15, 2025
@vercel

vercel Bot commented Jul 29, 2025

Copy link
Copy Markdown

@mpalmi is attempting to deploy a commit to the HashiCorp Team on Vercel.

A member of the Team first needs to authorize it.

@mpalmi mpalmi merged commit 9ff8f7e into hashicorp:main Jul 31, 2025
67 of 69 checks passed
@sapk

sapk commented Aug 19, 2025

Copy link
Copy Markdown

Hi. Maybe it could be a good idea to backport this fix for next release of 1.20.x as it block deployment in ha using a gcs bucket: #31125

sapk pushed a commit to sapk-fork/vault that referenced this pull request Oct 6, 2025
…ashicorp#31274)

After googleapis/google-cloud-go#11519, errors
must be checked with `errors.Is`.

Addresses hashicorp#31125.

Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants