Remove fmt strings and replace with inline queries#13799
Merged
imthaghost merged 5 commits intomainfrom Jan 27, 2022
Merged
Conversation
tomhjp
approved these changes
Jan 27, 2022
calvn
reviewed
Jan 27, 2022
Contributor
calvn
left a comment
There was a problem hiding this comment.
Can we apply the proper milestones and labels for the PR? It'd also be good to add a changelog entry for this.
@mickael-hc how far do you think we should be backporting this to?
calvn
approved these changes
Jan 27, 2022
calvn
reviewed
Jan 27, 2022
This was referenced Jan 27, 2022
imthaghost
pushed a commit
that referenced
this pull request
Jan 28, 2022
* removed fmt strings and replaced with inline SQL | added unit tests * changelog++
imthaghost
pushed a commit
that referenced
this pull request
Jan 28, 2022
* removed fmt strings and replaced with inline SQL | added unit tests * changelog++
imthaghost
pushed a commit
that referenced
this pull request
Jan 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed fmt strings and replaced them with inline queries and named parameters.