docs/helm: fix duplicate ingress tls section#13790
Merged
Conversation
Combined the two Ingress sections into one, hopefully in the right spot this time.
tomhjp
approved these changes
Jan 26, 2022
This was referenced Feb 4, 2022
fairclothjm
pushed a commit
that referenced
this pull request
Feb 12, 2022
Combined the two Ingress sections into one, hopefully in the right spot this time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combined the two Ingress TLS sections into one, hopefully in the right spot this time. I believe it should correspond to this
tlssection in the helm chart values file: https://github.com/hashicorp/vault-helm/blob/main/values.yaml#L302-L305