secrets/keymgmt: Adds documentation for using Azure Private Link#13640
Merged
austingebauer merged 2 commits intomainfrom Jan 13, 2022
Merged
secrets/keymgmt: Adds documentation for using Azure Private Link#13640austingebauer merged 2 commits intomainfrom
austingebauer merged 2 commits intomainfrom
Conversation
fairclothjm
approved these changes
Jan 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for configuring the Key Management secrets engine to communicate with a Key Vault instance over Azure Private Link. I set up this environment to ensure that the communication works as expected.
This also includes a small change to update AWS KMS documentation to replace the term customer master key (CMK) with AWS KMS key (see note on this terminology change).