Skip to content

GetCredentials Bug fix#13336

Merged
Monkeychip merged 2 commits intomainfrom
ui/get-creds-bug-fix
Dec 3, 2021
Merged

GetCredentials Bug fix#13336
Monkeychip merged 2 commits intomainfrom
ui/get-creds-bug-fix

Conversation

@Monkeychip
Copy link
Copy Markdown
Contributor

A regression bug caused by a required property added to the GetCredentialsCard component that was not added to a previous instance of the component.

Will backport to 1.9.x

@Monkeychip Monkeychip added backport bug Used to indicate a potential bug pr/no-changelog ui labels Dec 3, 2021
@Monkeychip Monkeychip added this to the 1.9.1 milestone Dec 3, 2021
@heatherezell heatherezell linked an issue Dec 3, 2021 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And a test! 😍

@Monkeychip Monkeychip merged commit 8f92d43 into main Dec 3, 2021
@Monkeychip Monkeychip deleted the ui/get-creds-bug-fix branch December 3, 2021 22:00
Monkeychip added a commit that referenced this pull request Dec 3, 2021
* the fix

* test coverage
Monkeychip added a commit that referenced this pull request Dec 3, 2021
* the fix

* test coverage
pull bot pushed a commit to NOUIY/vault that referenced this pull request Mar 27, 2026
…ce condition (hashicorp#13336) (hashicorp#13475)

* Add txnMutex to serialize MemDB transactions and fix race condition

* Added changelog

* Added tests

* Code cleanup

Co-authored-by: santoshhashicorp <santosh.yelamarthi@hashicorp.com>
pbromb pushed a commit to pbromb/vault that referenced this pull request Apr 13, 2026
…ce condition (hashicorp#13336) (hashicorp#13476) (hashicorp#13478)

* Add txnMutex to serialize MemDB transactions and fix race condition

* Added changelog

* Added tests

* Code cleanup

Co-authored-by: santoshhashicorp <santosh.yelamarthi@hashicorp.com>
MochaCaffe pushed a commit to kosmos-education/vault that referenced this pull request Apr 15, 2026
…ce condition (hashicorp#13336) (hashicorp#13477) (hashicorp#13481)

* Add txnMutex to serialize MemDB transactions and fix race condition

* Added changelog

* Added tests

* Code cleanup

Co-authored-by: santoshhashicorp <santosh.yelamarthi@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport bug Used to indicate a potential bug pr/no-changelog ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get Credentials button is disabled after upgrading to 1.9.0-ent

2 participants