Don't claim that Vault obfuscates the environment variable for sensitive values#13252
Merged
Don't claim that Vault obfuscates the environment variable for sensitive values#13252
Conversation
…ive values, this doesn't work at least in recent version of Go, as Go makes a copy of the environment, so we're only modifying that one, and not the one visible to the rest of the system
Contributor
|
5000 files changed… I’m assuming bc you need to merge to main, not master. |
Collaborator
Author
|
LOL, yes. My CLI github tool is old and doesn't properly figure out the main branch unless I tell it to. |
pull bot
pushed a commit
to benjivesterby/vault
that referenced
this pull request
Mar 27, 2026
…orp#13308) Co-authored-by: Angelo Cordon <angelo.cordon@hashicorp.com>
MochaCaffe
pushed a commit
to kosmos-education/vault
that referenced
this pull request
Apr 15, 2026
…orp#13308) (hashicorp#13484) Co-authored-by: Angelo Cordon <angelo.cordon@hashicorp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't work at least in recent version of Go, as Go makes a
copy of the environment, so we're only modifying that one, and not the one
visible to the rest of the system.