Respect WithWrappingToken for all secret ID's in approle auth#13241
Merged
Respect WithWrappingToken for all secret ID's in approle auth#13241
Conversation
|
|
…/vault into respect-wrapping-token
digivava
approved these changes
Nov 23, 2021
Collaborator
digivava
left a comment
There was a problem hiding this comment.
Awesome, thank you! Just one comment with something optional, but looks good to go otherwise.
pull bot
pushed a commit
to NOUIY/vault
that referenced
this pull request
Mar 23, 2026
…3309) * Add LDAP secrets engine blackbox tests * Format * format * cleanup environment * Install ldap-utils in CI for LDAP domain provisioning * wrap in eventually * debugging * fix ip issues * Add LDAP root credential rollback test * refactor rollback tests to fix race conditions and improve reliability * removed AI comment --------- Co-authored-by: shettykshitij <kshitij.shetty@hashicorp.com> Co-authored-by: LT Carbonell <ltcarbonell@pm.me> Co-authored-by: Luis (LT) Carbonell <lt.carbonell@hashicorp.com>
pbromb
pushed a commit
to pbromb/vault
that referenced
this pull request
Apr 13, 2026
…3312) (hashicorp#13315) * Add LDAP secrets engine blackbox tests * Format * format * cleanup environment * Install ldap-utils in CI for LDAP domain provisioning * wrap in eventually * debugging * fix ip issues * Add LDAP root credential rollback test * refactor rollback tests to fix race conditions and improve reliability * removed AI comment --------- Co-authored-by: shettykshitij <kshitij.shetty@hashicorp.com> Co-authored-by: LT Carbonell <ltcarbonell@pm.me> Co-authored-by: Luis (LT) Carbonell <lt.carbonell@hashicorp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
When authenticating with vault via AppRole, the secret ID can be specified in one of 3 ways:
FromFileFromEnvFromStringIf the secret ID happens to be a wrapping token, the option
auth.WithWrappingToken()will let the client know to treat it as such. However, the current implementation will only respectauth.WithWrappingToken()if the secret ID is specified from a file (FromFile) and silently fails otherwise, which could be surprising to callers.The rationale behind this was that the wrapping token should be provided through a trusted orchestrator and is typically written to a file. However, it is conceivable that the trusted orchestrator would write it to an environment variable instead.
Solution
This PR will respect the
auth.WithWrappingToken()for all secret ID's (whether specified viaFromFile,FromEnvorFromString)