Merged
Conversation
…roper error response
…_name} to returne proper error response
Contributor
|
Thanks for this submission! I'll get a review going as soon as I can. :) |
akshya96
approved these changes
Nov 22, 2021
…ll-token-type-bug
Contributor
|
Hi @ryowright - can you add a changelog entry please? Thanks! :) |
Contributor
Author
|
Hi @hsimon-hashicorp, just added a changelog entry. |
heppu
pushed a commit
to heppu/vault
that referenced
this pull request
Jan 13, 2022
* Fixed null token panic from 'v1/auth/token/' endpoints and returned proper error response
* Fixed panic resulting from null token_type in /auth/token/roles/{role_name} to returne proper error response
* added changelog entry for PR hashicorp#13236
* edit changelog entry for PR hashicorp#13236
eualin
pushed a commit
to eualin/vault
that referenced
this pull request
Mar 20, 2026
…ashicorp#13244) * Update vault-plugin-secrets-gcpkms to v0.23.0 (hashicorp#13236) --------- Co-authored-by: hc-github-team-secure-vault-ecosystem <hc-github-team-secure-vault-ecosystem@users.noreply.github.com> Co-authored-by: Maithy Ton <github@maithyton.com> * remove vault-plugin-secrets-keymgmt and vault-plugin-secrets-kmip imports --------- Co-authored-by: hc-github-team-secure-vault-ecosystem <hc-github-team-secure-vault-ecosystem@users.noreply.github.com> Co-authored-by: Maithy Ton <github@maithyton.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar fix to Issue #13225. Fixes panic resulting from
token_typefield being set tonullin a request body to /v1/auth/token/roles/{role_name} to return a proper error response instead. This a fix for Issue #13232 .