Skip to content

identity/oidc: optional nonce parameter for authorize request#13231

Merged
austingebauer merged 3 commits into
mainfrom
oidc-optional-nonce
Nov 22, 2021
Merged

identity/oidc: optional nonce parameter for authorize request#13231
austingebauer merged 3 commits into
mainfrom
oidc-optional-nonce

Conversation

@austingebauer

Copy link
Copy Markdown
Contributor

Overview

This PR makes the nonce parameter optional for the Authorization Endpoint published by Vault OIDC providers. It includes updates to documentation for this change.

Fixes #13204.

Additionally, this PR renames requiredClaims -> reservedClaims because it makes more sense as a variable name.

Testing

I've added test coverage to this PR. I also manually tested that the nonce isn't required and doesn't appear as an ID token claim when omitted.

@vercel vercel Bot temporarily deployed to Preview – vault November 19, 2021 23:59 Inactive
@vercel vercel Bot temporarily deployed to Preview – vault-storybook November 19, 2021 23:59 Inactive
@austingebauer austingebauer merged commit 87c355e into main Nov 22, 2021
@austingebauer austingebauer deleted the oidc-optional-nonce branch November 22, 2021 17:42
pull Bot pushed a commit to Zezo-Ai/vault that referenced this pull request Mar 20, 2026
…main (hashicorp#13231)

Co-authored-by: hc-github-team-secure-vault-ecosystem <hc-github-team-secure-vault-ecosystem@users.noreply.github.com>
Co-authored-by: Vinay Gopalan <vinay@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OIDC provider: nonce should be optional in authorization code flow

3 participants