Vault-2257: don't log token error on DR Secondary#13137
Merged
Conversation
HridoyRoy
suggested changes
Nov 12, 2021
Contributor
HridoyRoy
left a comment
There was a problem hiding this comment.
Suppressing the log messages looks good to me, but I had a quick follow-up question on the IsDRSecondary checks.
This reverts commit c036a1a.
This reverts commit 1e15aa5.
raskchanky
approved these changes
Nov 16, 2021
HridoyRoy
approved these changes
Nov 16, 2021
Contributor
HridoyRoy
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
swayne275
added a commit
that referenced
this pull request
Nov 17, 2021
* don't log token error on DR Secondary * stop gauge collector expiration errors on dr secondary * don't check dr secondary for token create * see if CI hits panic * Revert "don't check dr secondary for token create" This reverts commit c036a1a. * don't check dr secondary for token create * Revert "see if CI hits panic" This reverts commit 1e15aa5. * remove condition on log
swayne275
added a commit
that referenced
this pull request
Nov 17, 2021
* don't log token error on DR Secondary * stop gauge collector expiration errors on dr secondary * don't check dr secondary for token create * see if CI hits panic * Revert "don't check dr secondary for token create" This reverts commit c036a1a. * don't check dr secondary for token create * Revert "see if CI hits panic" This reverts commit 1e15aa5. * remove condition on log
swayne275
added a commit
that referenced
this pull request
Nov 17, 2021
* don't log token error on DR Secondary * stop gauge collector expiration errors on dr secondary * don't check dr secondary for token create * see if CI hits panic * Revert "don't check dr secondary for token create" This reverts commit c036a1a. * don't check dr secondary for token create * Revert "see if CI hits panic" This reverts commit 1e15aa5. * remove condition on log
swayne275
added a commit
that referenced
this pull request
Nov 17, 2021
* don't log token error on DR Secondary * stop gauge collector expiration errors on dr secondary * don't check dr secondary for token create * see if CI hits panic * Revert "don't check dr secondary for token create" This reverts commit c036a1a. * don't check dr secondary for token create * Revert "see if CI hits panic" This reverts commit 1e15aa5. * remove condition on log
swayne275
added a commit
that referenced
this pull request
Nov 17, 2021
* don't log token error on DR Secondary * stop gauge collector expiration errors on dr secondary * don't check dr secondary for token create * see if CI hits panic * Revert "don't check dr secondary for token create" This reverts commit c036a1a. * don't check dr secondary for token create * Revert "see if CI hits panic" This reverts commit 1e15aa5. * remove condition on log
swayne275
added a commit
that referenced
this pull request
Nov 17, 2021
* don't log token error on DR Secondary * stop gauge collector expiration errors on dr secondary * don't check dr secondary for token create * see if CI hits panic * Revert "don't check dr secondary for token create" This reverts commit c036a1a. * don't check dr secondary for token create * Revert "see if CI hits panic" This reverts commit 1e15aa5. * remove condition on log
eualin
pushed a commit
to eualin/vault
that referenced
this pull request
Mar 19, 2026
…) (hashicorp#13170) * updating transition for unsupported engines to route to config, code cleanup * test updates * updated tests to assert route & path are called with transition * fix assertions Co-authored-by: Dan Rivera <dan.rivera@hashicorp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looked like at least one of the two updated error messages was being hit on DR Secondaries, but after extensive testing I haven't found any evidence for that. Updating messages to identify if it does happen in the future.