Skip to content

Raft peer removal bug#13098

Merged
zofskeez merged 2 commits intomainfrom
ui/raft-peer-bug
Nov 9, 2021
Merged

Raft peer removal bug#13098
zofskeez merged 2 commits intomainfrom
ui/raft-peer-bug

Conversation

@zofskeez
Copy link
Copy Markdown
Contributor

@zofskeez zofskeez commented Nov 9, 2021

When removing a raft storage peer from the cluster via the CLI, the UI would not reflect the change until the page was refreshed. The findAll method returns everything from the store, which in this case included stale records since they were removed externally. After updating to use the query method, only records from the response are returned.

Testing

  • setup 2 vault servers using raft storage, one which will create a new cluster and the other who will join. Refer to this document for steps on setting that up.
  • hit /vault/storage/raft in the UI and verify both servers appear in Raft Storage list
  • remove a peer from the cli vault operator raft remove-peer name_of_raft_node
  • navigate away from route in UI and return (do not refresh since that will clear the store!)
  • clicking on status in the navbar and then Raft Storage should reveal only 1 server in the list

@vercel vercel bot temporarily deployed to Preview – vault November 9, 2021 17:21 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook November 9, 2021 17:27 Inactive
Copy link
Copy Markdown
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀

@zofskeez zofskeez added the ui label Nov 9, 2021
@zofskeez zofskeez merged commit 47024a2 into main Nov 9, 2021
@zofskeez zofskeez deleted the ui/raft-peer-bug branch November 9, 2021 22:05
@zofskeez zofskeez added this to the 1.10 milestone Nov 9, 2021
@zofskeez zofskeez modified the milestones: 1.10, 1.9.1, 1.7.7 Nov 17, 2021
@zofskeez zofskeez added bug Used to indicate a potential bug backport labels Nov 18, 2021
zofskeez added a commit that referenced this pull request Nov 18, 2021
* fixes issue removing raft peer via cli not reflected in UI until refresh

* adds changelog entry
zofskeez added a commit that referenced this pull request Nov 18, 2021
* fixes issue removing raft peer via cli not reflected in UI until refresh

* adds changelog entry
zofskeez added a commit that referenced this pull request Nov 18, 2021
* fixes issue removing raft peer via cli not reflected in UI until refresh

* adds changelog entry
@mladlow mladlow modified the milestones: 1.7.7, 1.7.9 Dec 14, 2021
zofskeez added a commit that referenced this pull request Jan 25, 2022
* Raft peer removal bug (#13098)

* fixes issue removing raft peer via cli not reflected in UI until refresh

* adds changelog entry

* removes faker

* attempts to fix global error in circle ci run
zofskeez added a commit that referenced this pull request Jan 25, 2022
* Raft peer removal bug (#13098)

* fixes issue removing raft peer via cli not reflected in UI until refresh

* adds changelog entry

* removes faker

* attempts to fix global error in circle ci run
zofskeez added a commit that referenced this pull request Jan 25, 2022
* Raft peer removal bug (#13098)

* fixes issue removing raft peer via cli not reflected in UI until refresh

* adds changelog entry

* removes faker

* attempts to fix global error in circle ci run
pbromb pushed a commit to pbromb/vault that referenced this pull request Apr 13, 2026
…) (hashicorp#13098) (hashicorp#13117)

Co-authored-by: mickael-hc <86245626+mickael-hc@users.noreply.github.com>
Co-authored-by: Steven Clark <steven.clark@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport bug Used to indicate a potential bug ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants