Conversation
ncabatoff
reviewed
Nov 8, 2021
Contributor
Author
|
i'm not sure if there's any value in updating the context used by tests. and if i do, i might want to have a helper to grab the context under stateLock thoughts @ncabatoff ? |
ncabatoff
reviewed
Nov 9, 2021
Collaborator
Let's not worry about the tests here unless they become a problem. |
ncabatoff
approved these changes
Nov 9, 2021
swayne275
added a commit
that referenced
this pull request
Nov 9, 2021
* update activity log to use core's activeContext for cleaner worker termination * update tests to use core activeContext instead of generic context * pass context around instead * revert context change * undo test context changes * change worker context * accidentally undid context for fcn signature changes
swayne275
added a commit
that referenced
this pull request
Nov 9, 2021
* update activity log to use core's activeContext for cleaner worker termination * update tests to use core activeContext instead of generic context * pass context around instead * revert context change * undo test context changes * change worker context * accidentally undid context for fcn signature changes
swayne275
added a commit
that referenced
this pull request
Nov 9, 2021
* update activity log to use core's activeContext for cleaner worker termination * update tests to use core activeContext instead of generic context * pass context around instead * revert context change * undo test context changes * change worker context * accidentally undid context for fcn signature changes
swayne275
added a commit
that referenced
this pull request
Nov 9, 2021
* update activity log to use core's activeContext for cleaner worker termination * update tests to use core activeContext instead of generic context * pass context around instead * revert context change * undo test context changes * change worker context * accidentally undid context for fcn signature changes
swayne275
added a commit
that referenced
this pull request
Nov 9, 2021
* update activity log to use core's activeContext for cleaner worker termination * update tests to use core activeContext instead of generic context * pass context around instead * revert context change * undo test context changes * change worker context * accidentally undid context for fcn signature changes
swayne275
added a commit
that referenced
this pull request
Nov 9, 2021
* update activity log to use core's activeContext for cleaner worker termination * update tests to use core activeContext instead of generic context * pass context around instead * revert context change * undo test context changes * change worker context * accidentally undid context for fcn signature changes
pbromb
pushed a commit
to pbromb/vault
that referenced
this pull request
Apr 13, 2026
…ontainers (hashicorp#12920) (hashicorp#13083) (hashicorp#13161) * update user directive for dockerfile run as vault user by default * add changelog * also set the user to vault in ent dockerfile * update changelog * add the user directive in the Dockerfile of the repo root it is the one used for production builds * remove user directive from build stage, add user directive to alpine stage Co-authored-by: mickael-hc <86245626+mickael-hc@users.noreply.github.com> Co-authored-by: Ryan Cragun <me@ryan.ec>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.