Backport cert diff algo signing #12514 to 1.8.x#12548
Merged
sgmiller merged 2 commits intorelease/1.8.xfrom Sep 15, 2021
Merged
Backport cert diff algo signing #12514 to 1.8.x#12548sgmiller merged 2 commits intorelease/1.8.xfrom
sgmiller merged 2 commits intorelease/1.8.xfrom
Conversation
#12514) * WIP: Unset the certificate's SignatureAlgorithm to allown cross-signing of different key types * Allow signing self issued certs with a different public key algorithm * Remove cruft * Remove stale import * changelog * eliminate errwrap * Add a test to cover the lack of opt-in flag * Better comment Co-authored-by: catsby <clint@ctshryock.com>
victorr
approved these changes
Sep 14, 2021
Contributor
victorr
left a comment
There was a problem hiding this comment.
I I verified that the changes were the same as in the original fix.
👍
eualin
pushed a commit
to eualin/vault
that referenced
this pull request
Apr 2, 2026
…#13556) * Create billing route and add to sidebar * WIP * Working dynamic cards * Update billing copy * Fix bugs * WIP polling * WIP Add polling.. * Move card logic to metric-card * Remove gcp KMS * Working polling * broken but just to demo normalization (hashicorp#12594) * broken but just to demo normalization * Pair with Claire to clean up data * Fix merge conflict issue * Create type file and add helper * Add unit test! * Add copywright headers * Update unit test name --------- * Fixes summary card component * Polling... * Fix ts errors * Write sidebar logic and add acceptance test * Add comment explaining license feature * Address feedback and fix styling so its responsive * Fix failing tests * Remove polling service and code clean up * Add changelog and update some styling! * Update changelog... --------- Co-authored-by: Kianna <30884335+kiannaquach@users.noreply.github.com> Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.