Adding support for SHA3 in the transit backend.#12150
Closed
robison wants to merge 1 commit intohashicorp:mainfrom
Closed
Adding support for SHA3 in the transit backend.#12150robison wants to merge 1 commit intohashicorp:mainfrom
robison wants to merge 1 commit intohashicorp:mainfrom
Conversation
12acd53 to
c70e409
Compare
c70e409 to
253c8c5
Compare
253c8c5 to
5f642df
Compare
5f642df to
9799ca1
Compare
Contributor
|
Hello @robison! I'm going to review your PR, but would you mind rebasing it in the meanwhile? Kind regards. |
victorr
requested changes
Nov 15, 2021
| @@ -0,0 +1,3 @@ | |||
| ```release-note:feature | |||
| transit: add support for sha3 in the transit backend | |||
Contributor
There was a problem hiding this comment.
Could you please update the description to something like:
secrets/transit: Add support for SHA-3 in the Transit backend.
| * sha3-224 | ||
| * sha3-256 | ||
| * sha3-384 | ||
| * sha3-512 |
Contributor
There was a problem hiding this comment.
It looks like you may not have noticed the tests in path_sign_verify_test.go. What about updating those as well?
| hf = sha512.New384() | ||
| case "sha2-512": | ||
| hf = sha512.New() | ||
| case "sha3-224": |
Contributor
There was a problem hiding this comment.
What about updating the documentation for this operation in vault/logical_system_paths.go?
Contributor
tsaarni
pushed a commit
to Nordix/vault
that referenced
this pull request
Mar 5, 2026
…ashicorp#12161) Update to the latest actions. The primary motivation here is to get the latest action-setup-enos. - actions/cache => v5.0.3: security patches - actions/checkout => v6.0.2: small fixes to git user-agent and tag fetching - hashicorp/action-setup-enos => v1.50: security patches Signed-off-by: Ryan Cragun <me@ryan.ec> Co-authored-by: Ryan Cragun <me@ryan.ec>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is intended to add support for SHA3 as a hashing algorithm in the
transitbackend. Feedback most appreciated!