tfexec: Enable graceful (SIGINT-based) cancellation#512
Conversation
84d3e2c to
7a5221f
Compare
7a5221f to
d72de79
Compare
|
Hi @radeksimko thanks for your effort to address this issue. However, I think this PR won't work as expected:
We found this issue when making our own implementation in #454. Hopefully it can be addressed in the main branch so we can switch to the official version again. Another difference between this PR and #454 is that we pass |
|
@wjf3121 I would be more than happy to address any outstanding issues if you can provide a way of reliably reproducing it, preferably in a form of a test. That applies to both As far as I can tell, the linked PR #454 does not contain test for either of these issues so it is hard to understand the nature of those problems and confirm that the code actually solves them. Correct me if I'm wrong. |
|
I am a bit late to the party, but we see the It would be great to get feedback or suggestions on how to fix the code, as the PR currently just contains the test case. Feedback is welcome. |
|
PR #527 provides a test and a fix, if anyone wants to have a look :) |
- Merged HashiCorp's terraform-exec main branch - Includes fix for graceful cancellation (issue hashicorp#389, PR hashicorp#512) - Preserved Martian Cloud custom color feature - Resolved conflicts in cmd.go, terraform.go, init.go, and workspace files
Closes #389
Changelog draft
os/execbehaviour)60sWaitDelayviaSetWaitDelay(time.Duration)Unwrapmaking it possible to pass it intoerrors.Asand access lower-level error such asexec.ExitError