feat: migrate AWS SDK from v1 to v2#299
Merged
kp2099 merged 2 commits intohashicorp:mainfrom Dec 15, 2025
Merged
Conversation
83a40fc to
21d2f53
Compare
aws-sdk-go v1 reached EOL at the end of July 2025. Replace aws-sdk-go v1.44.114 with aws-sdk-go-v2 modules and update AWS Secrets Manager implementation to use v2 patterns with context support and custom interfaces. Signed-off-by: Ville Vesilehto <ville.vesilehto@upcloud.com>
21d2f53 to
bbc2c83
Compare
Closed
kp2099
approved these changes
Dec 15, 2025
Contributor
kp2099
left a comment
There was a problem hiding this comment.
The changes look good to me. Thank you so much for your contribution!
Contributor
|
The release for this package and go mod update in packer, will probably happen in Jan 2026, considering code freeze at our org. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
aws-sdk-go v1 reached EOL at the end of July 2025.
Replace aws-sdk-go v1.44.114 with aws-sdk-go-v2 modules and update AWS Secrets Manager implementation to use v2 patterns with context support and custom interfaces.
Also noting that aws-sdk-go v1 is applicable to the following Go vulnerability reports:
Github CodeQL picks this up in Packer plugin implementations and complains about it.
After this is merged in the project still has an indirect dependency to aws-sdk-go v1. It comes from
hashicorp/go-getterand depends on this PR. hashicorp/go-getter#467Resolved Issues
None.
Rollback Plan
Easy to revert, after which the SDK is back on v1.
Changes to Security Controls
No.