Switch to github.com/aws/aws-sdk-go-v2#467
Conversation
|
|
5fa440d to
6100164
Compare
|
is this going to be merged soon? there is a timeline for this? |
|
AWS announced an EOL date for go sdk v1 recently - https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/
|
radeksimko
left a comment
There was a problem hiding this comment.
I don't have the capacity to review this more thoroughly at this point but one thing which stands out to me on a quick skim over is the old SDK v1 is still present in go.mod. It looks like all there's needed to address that is go mod tidy though.
6100164 to
531a6ec
Compare
|
@radeksimko Thank you for taking the time to look at the PR. I updated the PR, updating the file |
531a6ec to
34dcf29
Compare
8726138 to
6c5ba2e
Compare
6c5ba2e to
f2a3da8
Compare
get_s3.go
Outdated
| } | ||
| if lastMarker != "" { | ||
| req.Marker = aws.String(lastMarker) | ||
| req.Delimiter = aws.String(lastMarker) |
There was a problem hiding this comment.
I don't have as much experience with AWS SDK as Graham does but I'd think that delimiters are not typically used in the context of pagination. Graham mentioned earlier that we could use the native paginators, as documented at https://aws.github.io/aws-sdk-go-v2/docs/making-requests/#using-paginators
@lebauce have you considered that?
There was a problem hiding this comment.
@radeksimko Pagination is not supported in the current version if I'm not mistaken. Do we want to implement this in this PR ?
There was a problem hiding this comment.
@lebauce in this case pagination is making multiple requests to ListObjectsV2 while ContinuationToken is set (was Marker in ListObjects). In aws-sdk-go-v2, AWS has added the NewListObjectsV2Paginator that can be used to handle pagination instead of using a for loop.
|
I am also very interested in this functionality being added. Can we bubble this up? |
|
Hello folks, what is blocking this PR to move forward? Happy to help if needed |
The aws-sdk-go-v2 was announced as general availability
in 2021 and brings few advantages such as not storing
the endpoints list as a global variable, freeing memory.