Supercedes #455

PCI review checklist

• I have documented a clear reason for, and description of, the change I am making.

• If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.

• If applicable, I've documented the impact of any changes to security controls.

  Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

Overview

This PR comprehensively modernizes the go-getter codebase by addressing linting warnings, updating CI/CD workflows for better security and performance, and implementing idiomatic Go patterns.

Key Changes

CI/CD Workflow Improvements

• Updated Go versions: Migrated from Go 1.18/1.19 to modern 1.24/1.25
• Split test workflows: Separated basic validation (PRs) from integration tests (merges)
  • PRs now run fast unit tests without requiring cloud credentials
  • Integration tests with AWS/GCS credentials only run on main branch pushes
• Enhanced security: No cloud credentials exposed during PR validation

Code Modernization & Linting Fixes

• Eliminated deprecated io/ioutil: Replaced all usages with modern os package functions
  • ioutil.ReadFile → os.ReadFile
  • ioutil.TempDir → os.MkdirTemp
  • ioutil.TempFile → os.CreateTemp
• Modern Go patterns:
  • interface{} → any for improved readability
  • slices.Contains() instead of manual loops for better performance
  • Modern range over integers for cleaner iteration

AWS SDK Modernization

• Updated AWS S3 client configuration: Migrated from deprecated WithEndpointResolverWithOptions to modern BaseEndpoint configuration in NewFromConfig options
• Ensures compatibility with AWS SDK v2 best practices

Improved Test Architecture

• Smart credential handling: Tests requiring AWS/GCS credentials automatically skip in short mode
• Verbose CI output: Added -v flag to see exactly which tests run in validation

Benefits

• Faster PR validation: Unit tests complete in seconds
• Enhanced security: No cloud credentials needed for PR checks
• Better code quality: All linting warnings resolved
• Go best practices: Modern, idiomatic Go code patterns
• Comprehensive testing: Full integration coverage maintained on main branch

Testing

• All unit tests pass with go test -short
• Integration tests validated with full credentials
• No linting warnings remain
• CI/CD workflows tested and functional

This modernization brings the codebase up to current Go standards while significantly improving the developer experience and CI/CD security posture.