Closed
Conversation
960641c to
365ec0a
Compare
365ec0a to
0b6ad61
Compare
0b6ad61 to
b958efa
Compare
Contributor
|
Everyplace where we used ioutil.TempDir in tests could possibly be better served with testing's t.TempDir function, since it will clean them up automatically. |
Member
Author
|
Hi @angrycub, I have updated the branch to change tests to use t.TempDir() now. |
52a020b to
71addaf
Compare
71addaf to
b61a377
Compare
d31bfb8 to
76f18f6
Compare
Contributor
|
@tristanmorgan do you need help getting this reviewed? I registered this as an internal contributor change, which usually has its own workflow. It can be difficult to get changes reviewed in go-getter, due to the reluctance to disrupt anything for any of the products that use it. I'm assuming this change is with regards to a specific need. Let me know. |
Member
Author
|
if #549 is merged this one will be redundant. |
Merged
7 tasks
Member
|
Fixed by #549 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #451, replaces deprecated io/ioutil package usage.