Skip to content

Fix ipv6 addresses format#246

Merged
lbajolet-hashicorp merged 1 commit intohashicorp:mainfrom
jooola:fix-ipv6-ssh-addr-format
Jun 6, 2024
Merged

Fix ipv6 addresses format#246
lbajolet-hashicorp merged 1 commit intohashicorp:mainfrom
jooola:fix-ipv6-ssh-addr-format

Conversation

@jooola
Copy link
Copy Markdown
Contributor

@jooola jooola commented Jun 6, 2024

When joining an ipv6 host and a port, the host must be wrapped between brackets, otherwise the port will become part of the host.

Closes #245

When joining an ipv6 host and a port, the host must be wrapped between brackets, otherwise the port will become part of the host.
@jooola jooola requested a review from a team as a code owner June 6, 2024 10:41
@hashicorp-cla-app
Copy link
Copy Markdown

hashicorp-cla-app bot commented Jun 6, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jooola,

Thanks for the fix, TIL about both JoinHostPort and Sprint!

Merging now

@lbajolet-hashicorp lbajolet-hashicorp merged commit 9c1d243 into hashicorp:main Jun 6, 2024
@jooola jooola deleted the fix-ipv6-ssh-addr-format branch June 7, 2024 08:48
atrutnev added a commit to atrutnev/packer-plugin-yandex that referenced this pull request Jan 13, 2025
Remove extra brackets for IPv6 address because the latest version of packer-plugin-sdk already handles them - hashicorp/packer-plugin-sdk#246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IPv6 connection addresses are invalid, cannot connect via ssh

2 participants