Merged
Conversation
nywilken
suggested changes
Jan 21, 2022
Contributor
nywilken
left a comment
There was a problem hiding this comment.
I left a couple of suggestions but otherwise looks good.
String is a pointer for region Co-authored-by: Wilken Rivera <wilken@hashicorp.com>
Change test name Co-authored-by: Wilken Rivera <wilken@hashicorp.com>
nywilken
approved these changes
Jan 21, 2022
Contributor
nywilken
left a comment
There was a problem hiding this comment.
Happy we were able to talk abit about the changes. Approving, feel free to merge when ready.
* Add basic acceptance test * Add test fixture * Remove function for describing key pairs * Rename ebs example test to RSA Co-authored-by: Jenna Goldstrich <jenna.goldstrich@hashicorp.com>
Contributor
Author
|
Didn't realize that #182 was targeted at this PR's branch (step-key-pair-test), merging this now to merge both PRs I ran acceptance tests, and things hang on a test for me, but they hang on the same test on the main branch for me as well, I think this is due to my setup, the test we added works which I think would validate that we haven't broken anything with this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After reviewing #179 with Wilken we came to the conclusion that we should add a unit test to the KeyPair step so that the aforementioned PR can be tested (just need to remove comments in step_key_pair_test)
I ended up having to make a small change to each builder to put the region in the state before the steps are run, previously step_key_pair would access Region through the ec2 object (ec2conn.Config.Region), since we now cast that as an ec2iface to be able to mock it in the test, we are no longer able to access the Config object within the step, since the interface does not know about the Config object (might be an upstream fix there)