Wilken/step key pair test#182
Merged
JenGoldstrich merged 4 commits intostep-key-pair-testfrom Jan 21, 2022
Merged
Conversation
JenGoldstrich
approved these changes
Jan 21, 2022
Contributor
JenGoldstrich
left a comment
There was a problem hiding this comment.
LGTM, reviewed this with Wilken and switched it to an RSA test which can pass currently, will encourage contributor of original PR to add acceptance test for ed25519
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just adding an acceptance test for the keypair. It is a bit of a tricky test because it doesn't actually describe the keypair via the api but it does validated against the authorized_keys. You can add a test case for the ed25519 case when the other PRs are merge.