Merged
Conversation
Contributor
Author
|
can someone give me a review? |
findkim
reviewed
Oct 9, 2018
ifaddrs.go
Outdated
| return "", errors.New("No default interface found") | ||
| } | ||
|
|
||
| // parseDefaultIfNameFromIPCmd parses the default interface from ip(8) for |
There was a problem hiding this comment.
can you update the function name with the suffix Android?
Contributor
Author
There was a problem hiding this comment.
Thanks, Updated to parseDefaultIfNameFromIPCmdAndroid
Contributor
Author
|
Thanks |
Member
|
What's the reason to not support this? This is a library; Preeta's comment is about running an enterprise-grade scheduler on Nomad. I don't think they're equivalent. |
Member
|
Reopening for further discussion. |
Contributor
Author
|
Actually i agree, this is a library and not a nomad component, so it can have multiple applications. |
Contributor
|
Thank you for doing this @amfern, thank you for adding the bulk of this behind an android build tag . |
Contributor
Author
|
Just checking in, what stops it from being merged, do you need something from me? |
jefferai
reviewed
Mar 6, 2019
Allthough android is linux the 'ip route' command doesn't return 'default' line. Android has only one interface active at any time.
thaJeztah
added a commit
to thaJeztah/libnetwork
that referenced
this pull request
Aug 26, 2019
full diff: hashicorp/go-sockaddr@6d291a9...v1.0.2 Relevant changes: - hashicorp/go-sockaddr#25 Add android os - hashicorp/go-sockaddr#28 Add go.mod Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
Sep 3, 2019
full diff: hashicorp/go-sockaddr@6d291a9...v1.0.2 Relevant changes: - hashicorp/go-sockaddr#25 Add android os - hashicorp/go-sockaddr#28 Add go.mod Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Sep 3, 2019
full diff: hashicorp/go-sockaddr@6d291a9...v1.0.2 Relevant changes: - hashicorp/go-sockaddr#25 Add android os - hashicorp/go-sockaddr#28 Add go.mod Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 492945c2d553c1e8a13ad9c06aa2eb000d03f631 Component: engine
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
Sep 16, 2019
full diff: hashicorp/go-sockaddr@6d291a9...v1.0.2 Relevant changes: - hashicorp/go-sockaddr#25 Add android os - hashicorp/go-sockaddr#28 Add go.mod Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 492945c) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Sep 17, 2019
full diff: hashicorp/go-sockaddr@6d291a9...v1.0.2 Relevant changes: - hashicorp/go-sockaddr#25 Add android os - hashicorp/go-sockaddr#28 Add go.mod Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 492945c2d553c1e8a13ad9c06aa2eb000d03f631) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 5196dc65e7dae7f77be8b0f2f99eec5f967f529f Component: engine
burnMyDread
pushed a commit
to burnMyDread/moby
that referenced
this pull request
Oct 21, 2019
full diff: hashicorp/go-sockaddr@6d291a9...v1.0.2 Relevant changes: - hashicorp/go-sockaddr#25 Add android os - hashicorp/go-sockaddr#28 Add go.mod Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: zach <Zachary.Joyner@linux.com>
cpuguy83
pushed a commit
to cpuguy83/docker
that referenced
this pull request
May 25, 2021
full diff: hashicorp/go-sockaddr@6d291a9...v1.0.2 Relevant changes: - hashicorp/go-sockaddr#25 Add android os - hashicorp/go-sockaddr#28 Add go.mod Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allthough android is linux the 'ip route' command doesn't return 'default' line.
Android has only one interface active at any time.