template: distinguish templates with identical contents but different destinations or sources#2096
Merged
pkazmierczak merged 3 commits intomainfrom Oct 3, 2025
Merged
Conversation
destinations or sources
tgross
previously approved these changes
Sep 26, 2025
dduzgun-security
approved these changes
Oct 2, 2025
Contributor
dduzgun-security
left a comment
There was a problem hiding this comment.
LGTM, thanks for changing the md5 to sha256 part too.
tgross
approved these changes
Oct 2, 2025
pkazmierczak
added a commit
to hashicorp/nomad
that referenced
this pull request
Oct 3, 2025
This pulls latest consul-template to include the hashicorp/consul-template#2096 bugfix. Fixes #26800.
pkazmierczak
added a commit
to hashicorp/nomad
that referenced
this pull request
Oct 3, 2025
This pulls latest consul-template to include the hashicorp/consul-template#2096 bugfix. Fixes
pkazmierczak
added a commit
to hashicorp/nomad
that referenced
this pull request
Oct 3, 2025
…26880) This pulls latest consul-template to include the hashicorp/consul-template#2096 bugfix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consul Template should distinguish templates that have the same body but
different sources or destinations. In cases where a slice of templates is
submitted to the runner with same contents and a dependency, templates with the
same contents body will effectively be "merged" into one. See
hashicorp/nomad#26800 for an example of a bug caused by this.
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.