Merged
Conversation
test/index.js
Outdated
Contributor
Author
There was a problem hiding this comment.
It seemed unnecessary to me since when the plugin registration fails it passes an error to done() which in turn causes the test to fail. I'm fine adding an expect though if this isn't explicit enough.
Contributor
Author
|
@hueniverse I would appreciate it if you could confirm that I understood this issue correctly. |
Contributor
|
Looks good. |
26e1960 to
201311e
Compare
In some use cases it may make sense to load vision before any connections have been configured. Similarly, multiple plugins in an application may try to load vision. Since vision only deals with template rendering, it is possible to do both of these if the 'connections' and 'once' attributes are provided in the plugin attributes. Resolves hapijs#63.
201311e to
ba74ce7
Compare
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some use cases it may make sense to load vision before any
connections have been configured. Similarly, multiple plugins in an
application may try to load vision. Since vision only deals with
template rendering, it is possible to do both of these if the
'connections' and 'once' attributes are provided in the plugin
attributes.
Resolves #63.