Skip to content

Replace all of the backslashes in partial names to correctly name deeply nested partials.#5

Merged
hueniverse merged 1 commit intohapijs:masterfrom
Tagboard:loadPartials-multislash-replace
Nov 30, 2014
Merged

Replace all of the backslashes in partial names to correctly name deeply nested partials.#5
hueniverse merged 1 commit intohapijs:masterfrom
Tagboard:loadPartials-multislash-replace

Conversation

@heskew
Copy link
Copy Markdown
Contributor

@heskew heskew commented Oct 26, 2014

Allowing partial names like one/nested/partial to be used. Currently only the first backslash is replaced so it would be named one/nested\partial on Windows.

@hueniverse
Copy link
Copy Markdown
Contributor

Test?

@hueniverse hueniverse added the bug Bug or defect label Oct 29, 2014
@hueniverse hueniverse self-assigned this Oct 29, 2014
hueniverse pushed a commit that referenced this pull request Nov 30, 2014
Replace all of the backslashes in partial names to correctly name deeply nested partials.
@hueniverse hueniverse merged commit 6f8842f into hapijs:master Nov 30, 2014
@hueniverse hueniverse added this to the 2.0.0 milestone Nov 30, 2014
hueniverse added a commit that referenced this pull request Nov 30, 2014
@lock
Copy link
Copy Markdown

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Bug or defect

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants