Conversation
b2a0e67 to
4305ca4
Compare
README.md
Outdated
There was a problem hiding this comment.
I see no reason that it needs to be -- I just didn't have an async example on hand. I'm happy to rework it to be optionally async (and admittedly more consistent with the rest of the API). This seems to suggest a prepareMode option if it is going to parallel the compile function. Do you have any thoughts on this approach?
There was a problem hiding this comment.
compile mode was added for backwards compatibility issues. I would just do it async style and be done.
There was a problem hiding this comment.
Cool, will do. Thanks for the input!
4305ca4 to
c9bac11
Compare
|
@hueniverse I'm about ready to wrap this up. However, it looks like I'm not on the list of maintainers in NPM. Would you mind adding me to that so that I can publish |
Some view engines (i.e. Nunjucks) rely on the manager configuration and other state in order to render templates. This change provides a convenience method to allow engines to initialize any additional state and to update the engine configuration accordingly.
c9bac11 to
a6ef12b
Compare
|
Done |
|
Awesome. Thanks! |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Some view engines (i.e. Nunjucks) rely on the manager configuration
and other state in order to render templates. This change provides
a convenience method to allow engines to initialize any additional
state and to update the engine configuration accordingly.