Fix crash when no global context is supplied, no handler context is supplied, and a layout template is being used#17
Merged
arb merged 1 commit intohapijs:masterfrom Nov 13, 2014
Conversation
Contributor
|
If you recreate the situation described in #16, that should give you a test right? You know the situation you need to create to make this happen. The fact that coverage is still 100% means that both sides of |
Contributor
|
@Torsph I have created a test case for your reference. Feel free to pull/modify it as you see fit. |
Contributor
Author
…upplied, and a layout template is being used
14c8395 to
008c66d
Compare
Contributor
Author
|
@jagoda I just made the test name a bit more specific. |
Contributor
|
@Torsph cool. Works for me. |
arb
added a commit
that referenced
this pull request
Nov 13, 2014
Fix crash when no global context is supplied, no handler context is supplied, and a layout template is being used
Contributor
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix crash when no global context is supplied, no handler context is supplied, and a layout template is being used. Couldn't find a decent way to add a test, but the coverage is still 100% :)
Fixes #16