Merged
Conversation
Contributor
Author
devinivy
approved these changes
Jan 3, 2024
Member
devinivy
left a comment
There was a problem hiding this comment.
Looks great, thanks for getting this going 👍
Nargonath
approved these changes
Jan 4, 2024
Closed
Marsup
added a commit
that referenced
this pull request
Oct 23, 2024
* chore: change CI target for next * chore: add next branch to CI targets * feat: target ESLint v9 * Tighten type checking config (#1071) * Use more restrictive type signatures * Don't rely on broken expect.error() * chore: report node 18+ support (#1081) * chore: update documentation for eslint ignore --------- Co-authored-by: Gil Pedersen <git@gpost.dk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
noUncheckedIndexedAccess: trueandexactOptionalPropertyTypes: trueto the type checking config.This helps ensure that the defined typings can work for projects like reported here, which use these stricter than
strict: trueoptions.I also updated the peer dependency requirement to v4.4.0+, which is the oldest version that supports these flags.