Merged
Conversation
lib/any.js
Outdated
Collaborator
There was a problem hiding this comment.
This is not enough, you're only short-circuiting the non-function form of default (previous if).
Contributor
Author
There was a problem hiding this comment.
@Marsup you are right, i was looking for adding the minimum of complexity in this area, since there are plenty of conditions out there.
Let me know if it would be better to change each conditions to ensure that the "noDefaults" option is not set to "false".
Thanks !
Collaborator
|
It's OK like that. Can you add other tests with functions and refs ? Also squash the commits when you're done please. |
Contributor
Author
|
@Marsup all done ! |
Collaborator
|
Thanks. |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This option enables you to validate your data without applying default values into it.
Can be usefull when your default values are dynamic.
Corresponding issue: #682