Add IP Address Validation and Separate IP and URI Logic to Files#619
Add IP Address Validation and Separate IP and URI Logic to Files#619DavidTPate wants to merge 1 commit intohapijs:6.1.0from DavidTPate:separate-ip-and-uri
Conversation
|
@Marsup I got them split out where I thought they should be. I left the validation of options within |
lib/language.js
Outdated
There was a problem hiding this comment.
Regroup those under one option.
lib/string.js
Outdated
There was a problem hiding this comment.
You don't need that outside the loop.
|
You're missing many line breaks in the tests as well but I won't comment on all of them. |
|
Gotcha. I'll go through on the pieces you commented on, as well as the rest of the code. I've been getting more familiar with the coding style from the |
|
@Marsup I think it's all set now. I went through and tried to find all the syntax issues I could and addressed your feedback. I also figured out what I did wrong when trying to squash things before (I wasn't force pushing before), so I squashed the changes together. |
This PR adds the ability to do IP address validation and updates the handling of the components used to build Regular Expressions for both IP and URI validation into files. Additionally, this replaces the old usage of
Array.reduce()which was occurring before in both IP and URI validation construction in favor of the standardfor(...)loop.This resolves #607 and #617