Switch from Array.reduce() to a standard for loop#617
Closed
DavidTPate wants to merge 1 commit intohapijs:6.1.0from
DavidTPate:replace-reduce
Closed
Switch from Array.reduce() to a standard for loop#617DavidTPate wants to merge 1 commit intohapijs:6.1.0from DavidTPate:replace-reduce
DavidTPate wants to merge 1 commit intohapijs:6.1.0from
DavidTPate:replace-reduce
Conversation
… using `Array.reduce()` in a critical path.
Collaborator
|
I'd solve the other PR before piling up if I were you :) |
Contributor
Author
|
Closing this as #619 addresses it. |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches the usage of
Array.reduce()when create a piece of URI validation with one or more custom schemes to a standard for loop to reduce the footprint of the computations.@Marsup I did a quick search, and this was the only usage of reduce that I saw in Joi.